Bug 788 - Why is the copyright header commented out ?
Summary: Why is the copyright header commented out ?
Status: ASSIGNED
Alias: None
Product: BpmCount
Classification: Unclassified
Component: Packaging (show other bugs)
Version: 0.1
Hardware: PC Linux
: Future normal
Assignee: greg elliott
URL:
Depends on:
Blocks:
 
Reported: 2008-09-01 13:32 CEST by Werner Van Belle
Modified: 2008-09-01 21:12 CEST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 greg elliott 2008-09-01 21:12:43 CEST
(In reply to comment #0)
> I see no problem in a copyright header in the standalone program anyway. Maybe
> it is also not a bad idea to use the .so library itself to create bpmcount ?
> 
>         //DEPRECATE UNLESS WE STILL WANT A STAND-ALONE BINARY
>         // if (PRINT){
>         //      printf("BpmCount (c) Werner Van Belle, all rights reserved\n");
>         //      printf("library generation and porting to Windows and OS X by
> Greg Elliott\n");
>         //      printf("http://bpmcount.yellowcouch.org/\n");
>         //     
> printf("_________________________________________________________________\n");
>         // }
>         // if (argc==1)
>         // {
>         //      if (PRINT){
>         //              printf("Usage: bpmcount [file]*\n");
>         //              printf("The fileformat should be uncompressed\n");
>         //              printf("stereo, 16bit, little endian at 44100 Hz\n");
> 

i think you misread the code.  ALL of bpmcount is commented out, not just the copyright header.  

libbpm-example does the same thing that bpmcount does, but uses the .so object.  i wasn't sure if bpmcount was even needed anymore.

bpmcount, if we still want to keep it, should be a stand-alone that doesn't require the .so, otherwise it's just a redundant copy of libbpm-example.
Description Werner Van Belle 2008-09-01 13:32:26 CEST
I see no problem in a copyright header in the standalone program anyway. Maybe it is also not a bad idea to use the .so library itself to create bpmcount ?

        //DEPRECATE UNLESS WE STILL WANT A STAND-ALONE BINARY
        // if (PRINT){
        //      printf("BpmCount (c) Werner Van Belle, all rights reserved\n");
        //      printf("library generation and porting to Windows and OS X by Greg Elliott\n");
        //      printf("http://bpmcount.yellowcouch.org/\n");
        //      printf("_________________________________________________________________\n");
        // }
        // if (argc==1)
        // {
        //      if (PRINT){
        //              printf("Usage: bpmcount [file]*\n");
        //              printf("The fileformat should be uncompressed\n");
        //              printf("stereo, 16bit, little endian at 44100 Hz\n");